If programs were specified, only care about the state of the given ones #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. if foo is STOPPED and bar is RUNNING, if we've passed --programs bar, then the status of the check will be OK. Prior to this change it would be CRITICAL (or whatever you set --stopped-state to)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
E.g. if foo is STOPPED and bar is RUNNING, if we've passed --programs bar, then the status of the check will be OK. Prior to this change it would be CRITICAL (or whatever you set --stopped-state to)
Related Issue
Motivation and Context
If you're reporting the status of your programs individually, then without this change, all individual checks go critical when one program has an issue.
Also missing programs reported "not found in server response" but a status of OK, they now report as UNKNOWN.
How Has This Been Tested?
On the CLI for the various edge cases.